simulators/ethereum/engine: Fix state scheme issue in Geth node#1148
Merged
marioevz merged 4 commits intoethereum:masterfrom Aug 7, 2024
Merged
simulators/ethereum/engine: Fix state scheme issue in Geth node#1148marioevz merged 4 commits intoethereum:masterfrom
marioevz merged 4 commits intoethereum:masterfrom
Conversation
Member
Author
|
@Rjected please let me know if this fixes the issue for you. |
Contributor
yep, I no longer get |
fedacking
pushed a commit
to lambdaclass/hive
that referenced
this pull request
May 19, 2025
…reum#1148) * simulators/ethereum/engine: use legacy Hash state scheme * simulators/ethereum/engine: use new Path state scheme * simulators/ethereum/engine: add comment * simulators/ethereum/pyspec: go mod tidy
fedacking
pushed a commit
to lambdaclass/hive
that referenced
this pull request
May 19, 2025
…reum#1148) * simulators/ethereum/engine: use legacy Hash state scheme * simulators/ethereum/engine: use new Path state scheme * simulators/ethereum/engine: add comment * simulators/ethereum/pyspec: go mod tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1135
Issue had to do with the new path state scheme, and taking a look at the differences between our
SetBlockroutine and Geth'swriteBlockWithState, it seems like thetriedbcommitments are skipped in the new scheme:https://github.com/ethereum/go-ethereum/blob/aa55f5ea200dfd07618fdf658d9d2741c3b376a8/core/blockchain.go#L1481-L1485
Solution suggested by this PR is to (1) hard-code the configuration to use the new Path scheme from now on, and (2) if we are using this Path scheme, skip the trie database commitments.
All the "Invalid Missing Ancestor" tests from the engine simulator are now working.